katex test [nfc]: Name the KaTeX tests without redundancy after split #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajveermalviya
approved these changes
Jul 30, 2025
Member
rajveermalviya
left a comment
rajveermalviya
left a comment
There was a problem hiding this comment.
Thanks for doing this cleanup @gnprice! LGTM, Please merge at will.
The names beginning "mathBlockKatex…" were appropriate when the namespace these lived on was the more general ContentExample. But that prefix doesn't add anything when they're on KatexExample. (The fact they're in math blocks instead of inline math spans isn't part of the point of any of these examples.) Similarly the descriptions can be shortened; and then in some cases lengthened a bit again to say more about what each example is meant to exercise or illustrate.
This whole test file will be about KatexWidget and its associated private widgets, whether reached via MathBlock or via InlineContent. So a MathBlock group is no longer helpful, unlike when these tests lived in content_test.dart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small followup after #1729, cleaning up the KaTeX tests a bit more after splitting them from the other content tests.
Commit messages
cc0fb86 katex test [nfc]: Name the KatexExample statics without redundancy
The names beginning "mathBlockKatex…" were appropriate when the
namespace these lived on was the more general ContentExample.
But that prefix doesn't add anything when they're on KatexExample.
(The fact they're in math blocks instead of inline math spans isn't
part of the point of any of these examples.)
Similarly the descriptions can be shortened; and then in some cases
lengthened a bit again to say more about what each example is meant
to exercise or illustrate.
70b12af katex test [nfc]: Cut redundant group on KaTeX widget tests
This whole test file will be about KatexWidget and its associated
private widgets, whether reached via MathBlock or via InlineContent.
So a MathBlock group is no longer helpful, unlike when these tests
lived in content_test.dart.